Messages in this thread | | | Date | Thu, 20 Sep 2012 22:10:45 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH 4/5] charger-manager: Check fully charged state of battery periodically |
| |
On Tue, Aug 21, 2012 at 05:06:52PM +0900, Chanwoo Choi wrote: > This patch check periodically fully charged state of battery to protect > overcharge and overheat. If battery is fully charged, stop charging > and check droped voltage with 'fullbatt_vchkdrop_ms' period. When voltage > of battery is more droped than 'fullbatt_vchkdrop_uV' voltage, > charger-manager will restart charging for battery. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > ---
Applied, thank you.
There were some minor issues, but I fixed them up:
[...] > + } else if (!cm->emergency_stop > + && is_ext_pwr_online(cm) && !cm->charger_enabled) {
Wrong && placement (should have been on the previous line).
> + fullbatt_vchk(&cm->fullbatt_vchk_work.work); > + > + /* > + * Check whether fully charged state to protect overcharge > + * if charger-manager is charging for battery. > + */ > + } else if (!cm->emergency_stop > + && is_full_charged(cm) && cm->charger_enabled) {
Ditto.
| |