lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 22/26] block: Add bio_alloc_pages()
On Mon, Sep 10, 2012 at 05:22:33PM -0700, Kent Overstreet wrote:
> + bio_for_each_segment_all(bv, bio, i) {
> + bv->bv_page = alloc_page(gfp_mask);
> + if (!bv->bv_page) {
> + while (bv-- != bio->bi_io_vec)
> + __free_page(bv->bv_page);

I don't know. I feel stupid. I think it's because the loop variable
changes between loop condition test and actual body of loop. How
about the following? It is pointing to the member of the same array
so I think it's not even violating pointer comparison rules.

while (--bv >= bio->bi_io_vec)
__free_page(bv->bv_page);

--
tejun


\
 
 \ /
  Last update: 2012-09-21 03:21    [W:0.313 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site