lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 10/26] block: Add submit_bio_wait(), remove from md
On Thu, Sep 20, 2012 at 04:56:43PM -0700, Tejun Heo wrote:
> On Mon, Sep 10, 2012 at 05:22:21PM -0700, Kent Overstreet wrote:
> > Random cleanup - this code was duplicated and it's not really specific
> > to md.
> >
> > Also added the ability to return the actual error code.
> >
> > Signed-off-by: Kent Overstreet <koverstreet@google.com>
> > CC: Jens Axboe <axboe@kernel.dk>
> > CC: NeilBrown <neilb@suse.de>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> > --- a/include/linux/bio.h
> > +++ b/include/linux/bio.h
> > @@ -249,6 +249,7 @@ extern void bio_endio(struct bio *, int);
> > struct request_queue;
> > extern int bio_phys_segments(struct request_queue *, struct bio *);
> >
> > +extern int submit_bio_wait(int rw, struct bio *bio);
> > void bio_advance(struct bio *, unsigned);
>
> Heh, this is one of the reasons why I don't like extern on function
> prototypes. It's not necessary and people end up jumping between the
> two forms. :(

Yeah, I dislike it too but I was trying to follow the style in that file
- I did fix bio_advance() a few minutes ago.


\
 
 \ /
  Last update: 2012-09-21 02:41    [W:0.083 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site