| Date | Thu, 20 Sep 2012 16:56:43 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v2 10/26] block: Add submit_bio_wait(), remove from md |
| |
On Mon, Sep 10, 2012 at 05:22:21PM -0700, Kent Overstreet wrote: > Random cleanup - this code was duplicated and it's not really specific > to md. > > Also added the ability to return the actual error code. > > Signed-off-by: Kent Overstreet <koverstreet@google.com> > CC: Jens Axboe <axboe@kernel.dk> > CC: NeilBrown <neilb@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
> --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -249,6 +249,7 @@ extern void bio_endio(struct bio *, int); > struct request_queue; > extern int bio_phys_segments(struct request_queue *, struct bio *); > > +extern int submit_bio_wait(int rw, struct bio *bio); > void bio_advance(struct bio *, unsigned);
Heh, this is one of the reasons why I don't like extern on function prototypes. It's not necessary and people end up jumping between the two forms. :(
Thanks.
-- tejun
|