lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4] power_supply: add new lp8788 charger driver
Date
> -----Original Message-----
> From: Anton Vorontsov [mailto:anton.vorontsov@linaro.org]
> Sent: Friday, September 21, 2012 7:17 AM
> To: Kim, Milo
> Cc: David Woodhouse; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v4] power_supply: add new lp8788 charger driver
>
> On Wed, Sep 05, 2012 at 10:43:21AM +0000, Kim, Milo wrote:
> > TI LP8788 PMU supports regulators, battery charger, RTC,
> > ADC, backlight driver and current sinks.
> >
> > This patch supports the charger operations including
> > the charger interrupt handling.
> [...]
> > Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> > ---
>
> Had to fix a bunch of checkpatch complaints:
>
> CHECK: space prohibited before semicolon
> #478: FILE: drivers/power/lp8788-charger.c:396:
> + for (i = 0 ; i < pdata->num_chg_params ; i++) {
>
> CHECK: space prohibited before semicolon
> #541: FILE: drivers/power/lp8788-charger.c:459:
> + for (i = 0 ; i < pchg->num_irqs ; i++) {

Thanks a lot for this review.

It seems like the result of running checkpatch script with --strict option.
Should I keep this option whenever submitting the file?
I used to run w/o strict option.

>
>
> But other than this, it looks really good, this is now applied.
>
> Obviously, I couldn't compile-test it, but hopefully it will work
> once MFD part is also in. :-) If not, you can just send a follow-up
> fix.

Additionally, lp8788-charger depends on lp8788-adc driver.
I've found wrong calculation on getting the battery voltage and temperature.
I would submit this patch later.

I appreciate your help.

Best Regards,
Milo

\
 
 \ /
  Last update: 2012-09-21 02:01    [W:0.168 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site