lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 18/23] rcu: Adjust for unconditional ->completed assignment
    Date
    From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>

    Now that the rcu_node structures' ->completed fields are unconditionally
    assigned at grace-period cleanup time, they should already have the
    correct value for the new grace period at grace-period initialization
    time. This commit therefore inserts a WARN_ON_ONCE() to verify this
    invariant.

    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Reviewed-by: Josh Triplett <josh@joshtriplett.org>
    ---
    kernel/rcutree.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/kernel/rcutree.c b/kernel/rcutree.c
    index 5cb003d..71ae31b 100644
    --- a/kernel/rcutree.c
    +++ b/kernel/rcutree.c
    @@ -1078,6 +1078,7 @@ static int rcu_gp_init(struct rcu_state *rsp)
    rcu_preempt_check_blocked_tasks(rnp);
    rnp->qsmask = rnp->qsmaskinit;
    rnp->gpnum = rsp->gpnum;
    + WARN_ON_ONCE(rnp->completed != rsp->completed);
    rnp->completed = rsp->completed;
    if (rnp == rdp->mynode)
    rcu_start_gp_per_cpu(rsp, rnp, rdp);
    @@ -2775,7 +2776,8 @@ static void __init rcu_init_one(struct rcu_state *rsp,
    raw_spin_lock_init(&rnp->fqslock);
    lockdep_set_class_and_name(&rnp->fqslock,
    &rcu_fqs_class[i], fqs[i]);
    - rnp->gpnum = 0;
    + rnp->gpnum = rsp->gpnum;
    + rnp->completed = rsp->completed;
    rnp->qsmask = 0;
    rnp->qsmaskinit = 0;
    rnp->grplo = j * cpustride;
    --
    1.7.8


    \
     
     \ /
      Last update: 2012-09-20 22:41    [W:4.163 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site