Messages in this thread | | | Date | Thu, 20 Sep 2012 13:54:31 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH v2 3/5] KVM: MMU: cleanup FNAME(page_fault) |
| |
On 09/14/2012 12:58 PM, Xiao Guangrong wrote: > Let it return emulate state instead of spte like __direct_map > > Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> > --- > arch/x86/kvm/paging_tmpl.h | 28 ++++++++++------------------ > 1 files changed, 10 insertions(+), 18 deletions(-) > > diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h > index 92f466c..0adf376 100644 > --- a/arch/x86/kvm/paging_tmpl.h > +++ b/arch/x86/kvm/paging_tmpl.h > @@ -463,20 +463,18 @@ static void FNAME(pte_prefetch)(struct kvm_vcpu *vcpu, struct guest_walker *gw, > /* > * Fetch a shadow pte for a specific level in the paging hierarchy. > */ > -static u64 *FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr, > +static int FNAME(fetch)(struct kvm_vcpu *vcpu, gva_t addr, > struct guest_walker *gw, > int user_fault, int write_fault, int hlevel, > - int *emulate, pfn_t pfn, bool map_writable, > - bool prefault) > + pfn_t pfn, bool map_writable, bool prefault) > {
Please document the return value in the comment.
-- error compiling committee.c: too many arguments to function
| |