Messages in this thread | | | From | Irina Tirdea <> | Date | Sun, 2 Sep 2012 23:30:39 +0300 | Subject | Re: [PATCH 12/13] perf tools: replace on_exit with atexit |
| |
> Bernhard's patch implements on_exit. Why not go that route? > > The exit functions need the commands status to know whether to attempt to > process records. See: https://lkml.org/lkml/2012/8/26/123 > > Processing records on non-0 exit causes a segfault as the session has been > deleted.
I was trying to avoid as much as possible adding implementations for functions in perf. Considering the patch you mentioned and the need to know the exit status, looks like Bernhard's solution is the best approach in this case. I will use his on_exit wrapper and drop this patch.
Thanks, Irina
| |