lkml.org 
[lkml]   [2012]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 03/27] audit: Limit audit requests to processes in the initial pid and user namespaces.
    From: "Eric W. Biederman" <ebiederm@xmission.com>

    This allows the code to safely make the assumption that all of the
    uids gids and pids that need to be send in audit messages are in the
    initial namespaces.

    If someone cares we may lift this restriction someday but start with
    limiting access so at least the code is always correct.

    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Eric Paris <eparis@redhat.com>
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    ---
    kernel/audit.c | 6 ++++++
    1 files changed, 6 insertions(+), 0 deletions(-)

    diff --git a/kernel/audit.c b/kernel/audit.c
    index ea3b7b6..7b7268e 100644
    --- a/kernel/audit.c
    +++ b/kernel/audit.c
    @@ -61,6 +61,7 @@
    #include <linux/netlink.h>
    #include <linux/freezer.h>
    #include <linux/tty.h>
    +#include <linux/pid_namespace.h>

    #include "audit.h"

    @@ -588,6 +589,11 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
    {
    int err = 0;

    + /* Only support the initial namespaces for now. */
    + if ((current_user_ns() != &init_user_ns) ||
    + (task_active_pid_ns(current) != &init_pid_ns))
    + return -EPERM;
    +
    switch (msg_type) {
    case AUDIT_GET:
    case AUDIT_LIST:
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2012-09-20 04:21    [W:7.088 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site