lkml.org 
[lkml]   [2012]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] mm: remove vma arg from page_evictable
    On Tue, Sep 18, 2012 at 08:53:45PM -0700, Hugh Dickins wrote:
    > page_evictable(page, vma) is an irritant: almost all its callers pass
    > NULL for vma. Remove the vma arg and use mlocked_vma_newpage(vma, page)
    > explicitly in the couple of places it's needed. But in those places we
    > don't even need page_evictable() itself! They're dealing with a freshly
    > allocated anonymous page, which has no "mapping" and cannot be mlocked yet.
    >
    > Signed-off-by: Hugh Dickins <hughd@google.com>
    > Cc: Mel Gorman <mel@csn.ul.ie>
    > Cc: Rik van Riel <riel@redhat.com>
    > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > Cc: Michel Lespinasse <walken@google.com>
    > Cc: Ying Han <yinghan@google.com>

    Much better. With documentation updates and everything, thank you!

    Acked-by: Johannes Weiner <hannes@cmpxchg.org>


    \
     
     \ /
      Last update: 2012-09-19 19:41    [W:3.651 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site