Messages in this thread | | | Date | Tue, 18 Sep 2012 10:40:53 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host |
| |
On Tue, Sep 18, 2012 at 09:30:06AM +0530, navin patidar wrote: > stub_device_reset should set kernel thread pointers to NULL. > so that at the time of usbip_host removal stub_shoutdown_connection > doesn't try to kill kernel threads which are already killed. >
If you have the Oops output, that's always nice to put in the commit message.
Why don't you set the pointers to NULL in stub_shutdown_connection() since that's where you actually kill the threads. Setting them to NULL in stub_device_reset() will (sometimes) solve the problem but it gives you a new problem of a resource leak.
regards, dan carpenter
| |