Messages in this thread | | | Date | Tue, 18 Sep 2012 20:42:44 -0700 | Subject | Re: [PATCH] poweroff: fix bug in orderly_poweroff | From | Kees Cook <> |
| |
On Tue, Sep 18, 2012 at 8:27 PM, hongfeng <hongfeng@marvell.com> wrote: > orderly_poweroff is trying to poweroff platform by two steps: > step 1: Call userspace application to poweroff > step 2: If userspace poweroff fail, then do a force power off if force param is set. > > The bug here is, step 1 is always successful with param UMH_NO_WAIT, > should change to UMH_WAIT_PROC which will monitor the return value ofuserspace application. > > Signed-off-by: Feng Hong <hongfeng@marvell.com>
Seems right to me.
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook Chrome OS Security
| |