lkml.org 
[lkml]   [2012]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 7/9] ARM: OMAP: iommu: optimize save and restore routines
    From
    Hi Tony,

    On 18 September 2012 13:04, Tony Lindgren <tony@atomide.com> wrote:
    > * Omar Ramirez Luna <omar.luna@linaro.org> [120912 12:47]:
    >> --- a/arch/arm/plat-omap/include/plat/iommu.h
    >> +++ b/arch/arm/plat-omap/include/plat/iommu.h
    >> @@ -27,6 +27,13 @@ struct iotlb_entry {
    >> };
    >> };
    >>
    >> +/* context registers */
    >> +struct iommu_regs {
    >> + u32 irqen;
    >> + u32 cntl;
    >> + u32 ttb;
    >> +};
    >> +
    >> struct omap_iommu {
    >> const char *name;
    >> struct module *owner;
    >> @@ -50,7 +57,8 @@ struct omap_iommu {
    >> struct list_head mmap;
    >> struct mutex mmap_lock; /* protect mmap */
    >>
    >> - void *ctx; /* iommu context: registres saved area */
    >> + struct iommu_regs context;
    >> + int ctx_loss_cnt;
    >> u32 da_start;
    >> u32 da_end;
    >> };
    >> --- a/arch/arm/plat-omap/include/plat/iommu2.h
    >> +++ b/arch/arm/plat-omap/include/plat/iommu2.h
    >> @@ -35,8 +35,6 @@
    >> #define MMU_READ_RAM 0x6c
    >> #define MMU_EMU_FAULT_AD 0x70
    >>
    >> -#define MMU_REG_SIZE 256
    >> -
    >> /*
    >> * MMU Register bit definitions
    >> */
    >
    > These headers should be moved to include/linux/platform_data/iommu-omap.h
    > or something like that. Care to take care of that too?
    >
    > I guess there's no reason to have both iommu.h and iommuh2.h?

    Agree, can this be made as part of a separate cleanup series? I was
    hoping these could make it for 3.7 so we could have a usable rpmsg for
    omap4.

    Regards,

    Omar


    \
     
     \ /
      Last update: 2012-09-19 03:21    [W:4.627 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site