Messages in this thread | | | Date | Tue, 18 Sep 2012 17:15:29 +0100 | From | Alasdair G Kergon <> | Subject | Re: [dm-devel] [PATCH v10 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc() |
| |
On Mon, Sep 17, 2012 at 01:42:27PM -0700, Kent Overstreet wrote: > Previously, it was open coding __bio_clone(), that's what the setting > bi_idx to 0 was from. With the change to bio_clone_bioset() that's no > longer necessary (and dangerous, since bi_idx needs to be consistent > with bi_sector/bi_size).
It was performing a partial clone, deleting any no-longer-needed entries from the array. This patch undoes that which is presumably OK because you propose to eliminate them again in a later one of your patches.
Alasdair
| |