lkml.org 
[lkml]   [2012]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] drivers/mmc/host/dw_mmc.c: fix error return code
    Date
    From: Peter Senna Tschudin <peter.senna@gmail.com>

    Convert a nonnegative error return code to a negative one, as returned
    elsewhere in the function.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }
    // </smpl>

    Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
    ---
    drivers/mmc/host/dw_mmc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
    index 36f98c0..7ad5176 100644
    --- a/drivers/mmc/host/dw_mmc.c
    +++ b/drivers/mmc/host/dw_mmc.c
    @@ -2039,8 +2039,10 @@ int dw_mci_probe(struct dw_mci *host)
    tasklet_init(&host->tasklet, dw_mci_tasklet_func, (unsigned long)host);
    host->card_workqueue = alloc_workqueue("dw-mci-card",
    WQ_MEM_RECLAIM | WQ_NON_REENTRANT, 1);
    - if (!host->card_workqueue)
    + if (!host->card_workqueue) {
    + err = -ENOMEM;
    goto err_dmaunmap;
    + }
    INIT_WORK(&host->card_work, dw_mci_work_routine_card);
    ret = request_irq(host->irq, dw_mci_interrupt, host->irq_flags, "dw-mci", host);
    if (ret)
    --
    1.7.11.4


    \
     
     \ /
      Last update: 2012-09-17 11:01    [W:4.711 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site