lkml.org 
[lkml]   [2012]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/6] media: input: convert to c99 format
Date
On Mon September 17 2012 17:22:27 Shubhrajyoti D wrote:
> The series tries to convert the i2c_msg to c99 struct.
> This may avoid issues like below if someone tries to add an
> element to the structure.
> http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg08972.html

I'm OK with this provided that these intializations are formatted with
one field per line. It's rather hard to read otherwise since the lines
are now a lot longer.

Regards,

Hans

> Special thanks to Julia Lawall for helping it automate.
> By the below script.
> http://www.mail-archive.com/cocci@diku.dk/msg02753.html
>
> Checkpatch warn of more than 80 chars have been ignored.
>
> Shubhrajyoti D (6):
> media: Convert struct i2c_msg initialization to C99 format
> media: Convert struct i2c_msg initialization to C99 format
> media: Convert struct i2c_msg initialization to C99 format
> media: Convert struct i2c_msg initialization to C99 format
> media: Convert struct i2c_msg initialization to C99 format
> media: Convert struct i2c_msg initialization to C99 format
>
> drivers/media/i2c/ks0127.c | 4 ++--
> drivers/media/i2c/msp3400-driver.c | 12 ++++++------
> drivers/media/i2c/tvaudio.c | 4 ++--
> drivers/media/radio/radio-tea5764.c | 6 +++---
> drivers/media/radio/saa7706h.c | 4 ++--
> drivers/media/radio/si470x/radio-si470x-i2c.c | 12 ++++++------
> 6 files changed, 21 insertions(+), 21 deletions(-)
>
>


\
 
 \ /
  Last update: 2012-09-17 18:21    [W:0.066 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site