lkml.org 
[lkml]   [2012]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources
    From
    On Mon, Sep 17, 2012 at 9:57 AM, Inderpal Singh
    <inderpal.singh@linaro.org> wrote:
    > Since 0 is not considered as error at dmaengine level, return ENOMEM
    > from pl330_alloc_chan_resources in case of failure.
    >
    > Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>

    Acked-by: Jassi Brar <jassisinghbrar@gmail.com>


    > ---
    > drivers/dma/pl330.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
    > index e4feba6..14d881c 100644
    > --- a/drivers/dma/pl330.c
    > +++ b/drivers/dma/pl330.c
    > @@ -2393,7 +2393,7 @@ static int pl330_alloc_chan_resources(struct dma_chan *chan)
    > pch->pl330_chid = pl330_request_channel(&pdmac->pif);
    > if (!pch->pl330_chid) {
    > spin_unlock_irqrestore(&pch->lock, flags);
    > - return 0;
    > + return -ENOMEM;
    > }
    >
    > tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
    > --
    > 1.7.9.5
    >


    \
     
     \ /
      Last update: 2012-09-17 08:41    [W:4.039 / U:1.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site