Messages in this thread | | | Date | Mon, 17 Sep 2012 11:52:12 +0100 | From | Stefano Stabellini <> | Subject | Re: [PATCH 08/10] xen/swiotlb: Remove functions not needed anymore. |
| |
On Fri, 14 Sep 2012, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 14, 2012 at 05:06:16PM +0100, Stefano Stabellini wrote: > > On Mon, 10 Sep 2012, Konrad Rzeszutek Wilk wrote: > > > Sparse warns us off: > > > drivers/xen/swiotlb-xen.c:506:1: warning: symbol 'xen_swiotlb_map_sg' was not declared. Should it be static? > > > drivers/xen/swiotlb-xen.c:534:1: warning: symbol 'xen_swiotlb_unmap_sg' was not declared. Should it be static? > > > > > > and it looks like we do not need this function at all. > > > > A grep seems to find them used in arch/x86/xen/pci-swiotlb-xen.c. > > I fail to see where you removed them from pci-swiotlb-xen.c. Is it in > > this patch series or another one? > > I am not seeing them in that file. I think you found the > other variant of it: > > xen_swiotlb_map_sg_attrs
Yes, you are right.
| |