lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing
    On Thu, Sep 06, 2012 at 03:34:55PM -0700, Kent Overstreet wrote:
    > With the old code, when you allocate a bio from a bio pool you have to
    > implement your own destructor that knows how to find the bio pool the
    > bio was originally allocated from.
    >
    > This adds a new field to struct bio (bi_pool) and changes
    > bio_alloc_bioset() to use it. This makes various bio destructors
    > unnecessary, so they're then deleted.
    >
    > v6: Explain the temporary if statement in bio_put

    This patch also silently reverts
    commit 4d7b38b7d944a79da3793b6c92d38682f3905ac9
    "dm: clear bi_end_io on remapping failure"

    Why?

    If it's intentional, please explain it in your patch header and
    copy Hannes to reconsider the matter.

    If it wasn't intentional, please reinstate it.

    Alasdair



    \
     
     \ /
      Last update: 2012-09-14 21:01    [W:4.572 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site