lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/1] pinctrl: Samsung: Fix return value
Date
Return the value obtained from of_property_count_strings()
instead of -EINVAL.

Silences the following smatch warning:
drivers/pinctrl/pinctrl-samsung.c:529 samsung_pinctrl_parse_dt_pins()
info: why not propagate '*npins' from of_property_count_strings()
instead of -22?

Cc: Thomas Abraham <thomas.ab@samsung.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-samsung.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 8a24223..824fda9 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -526,7 +526,7 @@ static int __init samsung_pinctrl_parse_dt_pins(struct platform_device *pdev,
*npins = of_property_count_strings(cfg_np, "samsung,pins");
if (*npins < 0) {
dev_err(dev, "invalid pin list in %s node", cfg_np->name);
- return -EINVAL;
+ return *npins;
}

*pin_list = devm_kzalloc(dev, *npins * sizeof(**pin_list), GFP_KERNEL);
--
1.7.4.1


\
 
 \ /
  Last update: 2012-09-14 14:41    [W:0.054 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site