lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux
On 09/13/2012 09:52 AM, Linus Walleij wrote:
> On Wed, Sep 12, 2012 at 10:27 PM, Tony Lindgren <tony@atomide.com> wrote:
>> * Peter Ujfalusi <peter.ujfalusi@ti.com> [120911 01:54]:
>>> With pinctrl-single,bits it is possible to update just part of the register
>>> within the pinctrl-single,function-mask area.
>>> This is useful when one register configures mmore than one pin's mux.
>>
>>> size /= sizeof(*mux); /* Number of elements in array */
>>> - rows = size / 2; /* Each row is a key value pair */
>>> + rows = size / params; /* Each row is a key value pair */
>>
>> Maybe just remove the comment: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> I don't think it's needed any longer. Other than that,
>> thanks for updating the patch:
>>
>> Acked-by: Tony Lindgren <tony@atomide.com>
>
> Applied minus the comment, plus Tony's ACK, thanks!

Thank you Linus, I was about to send the v3 with the removed comment.

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-09-13 10:21    [W:0.034 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site