lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dma: tegra: use list_move_tail instead of list_del/list_add_tail
From
Date
On Wed, 2012-09-05 at 15:08 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied thanks
> ---
> drivers/dma/tegra20-apb-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 24acd71..6ed3f43 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -475,8 +475,7 @@ static void tegra_dma_abort_all(struct tegra_dma_channel *tdc)
> while (!list_empty(&tdc->pending_sg_req)) {
> sgreq = list_first_entry(&tdc->pending_sg_req,
> typeof(*sgreq), node);
> - list_del(&sgreq->node);
> - list_add_tail(&sgreq->node, &tdc->free_sg_req);
> + list_move_tail(&sgreq->node, &tdc->free_sg_req);
> if (sgreq->last_sg) {
> dma_desc = sgreq->dma_desc;
> dma_desc->dma_status = DMA_ERROR;
> @@ -570,8 +569,7 @@ static void handle_cont_sngl_cycle_dma_done(struct tegra_dma_channel *tdc,
>
> /* If not last req then put at end of pending list */
> if (!list_is_last(&sgreq->node, &tdc->pending_sg_req)) {
> - list_del(&sgreq->node);
> - list_add_tail(&sgreq->node, &tdc->pending_sg_req);
> + list_move_tail(&sgreq->node, &tdc->pending_sg_req);
> sgreq->configured = false;
> st = handle_continuous_head_request(tdc, sgreq, to_terminate);
> if (!st)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


--
~Vinod



\
 
 \ /
  Last update: 2012-09-14 05:41    [W:0.051 / U:2.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site