Messages in this thread |  | | From | Federico Vaga <> | Subject | Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator | Date | Thu, 13 Sep 2012 20:27:21 +0200 |
| |
In data giovedì 13 settembre 2012 11:45:31, Jonathan Corbet ha scritto: > On Thu, 13 Sep 2012 17:46:32 +0200 > > Federico Vaga <federico.vaga@gmail.com> wrote: > > > A few words explaining why this memory handling module is required > > > or > > > beneficial will definitely improve the commit :) > > > > ok, I will write some lines > > In general, all of these patches need *much* better changelogs (i.e. > they need changelogs). What are you doing, and *why* are you doing > it? The future will want to know.
I can improve the comment about the ADV7180: it is not clear why I'm removing that functions. (and the memory allocator commit is also in the todo list).
The STA2X11_VIP commit, I think is clear, I convert it to use videobu2 and control framework. I can add some extra lines to explain why: because videobuf is obsolete
> I'm going to try to look at the actual code, but time isn't something > I have a lot of, still...
The actual code is the same of the previous one with yours (plural) suggestions from the RFC submission (few week ago). I did not write anything else.
-- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |