lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/24] Staging: ipack/devices/ipoctal: Store isr masks in ipoctal_channel
On Thu, Sep 13, 2012 at 08:43:12PM +0300, Dan Carpenter wrote:
> On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge <jens.taprogge@taprogge.org>
> >
> > This way interrupt handling becomes independent of the channel number.
> >
> > Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
> > ---
> > @@ -213,7 +206,7 @@ static int ipoctal_irq_handler(void *arg)
> > }
> >
> > /* RX data */
> > - if (isr_rx_rdy && (sr & SR_RX_READY)) {
> > + if ((isr && channel->isr_rx_rdy_mask) && (sr & SR_RX_READY)) {
> ^^
> Bitwise AND intended here I think.
>

Never mind. It gets silently fixed in the next patch.

Regards,
dan carpenter



\
 
 \ /
  Last update: 2012-09-13 20:41    [W:0.061 / U:5.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site