lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Fix queueing work if !bdi_cap_writeback_dirty()
Date
Fengguang Wu <fengguang.wu@intel.com> writes:

>> >> I tested by custom bdi with BDI_CAP_NO_WRITEBACK - sync(2) blocked
>> >> forever by this reason.
>> >
>> > What's your test script? How do you create/use that custom bdi?
>>
>> Ah, I wrote my kernel module to test. I guess there is no users in
>> current kernel for now, because it doesn't work.
>
> OK. Got it. So I'd suggest to change the first chunk to a VM_BUG_ON(),
> which should be enough to catch new bad callers. The other two chunks
> look fine.

Hm, if it changed to VM_BUG_ON(), we can't use BDI_CAP_NO_WRITEBACK to
disable the writeback task (but allow inode cache reclaim) after all.

Or you meant we don't allow to disable the writeback task?

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2012-09-13 09:01    [W:0.056 / U:22.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site