Messages in this thread | | | Date | Thu, 13 Sep 2012 17:08:26 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/2] coredump: pass siginfo_t* to do_coredump() and below, not merely signr |
| |
On 09/13, Denys Vlasenko wrote: > > This is a preparatory patch for the introduction of NT_SIGINFO elf note.
I think the changelog should explain what the patch does.
With this patch we pass "siginfo_t *info" instead of "int signr" to do_coredump() and put it into coredump_params, this "info" will be used by the next patch. Other changes are simple s/signr/info->si_signo/.
> @@ -524,7 +524,7 @@ void do_coredump(long signr, int exit_code, struct pt_regs *regs) > */ > clear_thread_flag(TIF_SIGPENDING); > > - ispipe = format_corename(&cn, signr); > + ispipe = format_corename(&cn, info->si_signo);
Well, this conflicts with another fix which we discussed privately, perhaps it would be better to push that simple change first... But OK, this conflict is trivial.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
| |