lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] sound fixes for 3.6-rc6
At Thu, 13 Sep 2012 09:03:44 -0400,
Jeff King wrote:
>
> On Thu, Sep 13, 2012 at 02:28:51PM +0200, Takashi Iwai wrote:
>
> > > FWIW, it was an output from git-pull-request, which fell back to the
> > > equivalent branch. Usually I check it manually but I forgot it at
> > > this time just before going to a meeting.
> > >
> > > This was with git 1.7.11.5. I'll check whether this still happens
> > > with 1.7.12.
> >
> > The same problem still happens with git 1.7.12.
> > This is rather annoying than useful.
>
> I can't reproduce here. What is your exact request-pull invocation? Is
> request-pull showing a warning like:
>
> warn: You locally have sound-3.6 but it does not (yet)
> warn: appear to be at git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> warn: Do you want to push it there, perhaps?

Hm, it looks like the check is performed only for tag objects.
In the example below, no warning appears:
% git tag mytest for-next
% git request-pull mytest~ git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git mytest

With an annotated or a signed tag, git seems giving a warning like
above, indeed. So my test seemed wrong. Sorry for the noise.

In the previous case, I don't know what really screwed up, since it
was against a signed tag. Maybe I overlooked the warning as I'm
redirecting the output to a file.

> (it should do so since v1.7.11.2). Maybe we need to make it possible to
> bump that warning to a fatal error?

Yes, please! It's easily overlooked.
Better to be "strict but correct" than "friendly but wrong".

Just give an option to ignore the error if people really want to
ignore it.


thanks,

Takashi


\
 
 \ /
  Last update: 2012-09-13 16:21    [W:0.043 / U:27.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site