lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device.
From
Date
On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge <jens.taprogge@taprogge.org>
> >
> > The field irq currently is identical to the slot number. It does not seem to
> > have any real use. The number is written to hardware in ipoctal but it seems
> > the value that is written does not matter.
> >
> > Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
> > ---
> > - iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> > + iowrite8(1, ipoctal->dev->mem_space.address + 1);
>
> It might be nice to put a /* dummy write */ comment here.
>

Added! Thanks for the suggestion,

Sam

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-09-13 13:01    [W:0.043 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site