Messages in this thread |  | | Date | Thu, 13 Sep 2012 13:01:45 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device. |
| |
On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote: > From: Jens Taprogge <jens.taprogge@taprogge.org> > > The field irq currently is identical to the slot number. It does not seem to > have any real use. The number is written to hardware in ipoctal but it seems > the value that is written does not matter. > > Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> > --- > - iowrite8(vector, ipoctal->dev->mem_space.address + 1); > + iowrite8(1, ipoctal->dev->mem_space.address + 1);
It might be nice to put a /* dummy write */ comment here.
regards, dan carpenter
|  |