lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device.
On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge <jens.taprogge@taprogge.org>
>
> The field irq currently is identical to the slot number. It does not seem to
> have any real use. The number is written to hardware in ipoctal but it seems
> the value that is written does not matter.
>
> Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
> ---
> - iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> + iowrite8(1, ipoctal->dev->mem_space.address + 1);

It might be nice to put a /* dummy write */ comment here.

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-09-13 12:41    [W:0.038 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site