Messages in this thread |  | | Subject | RE: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree | Date | Thu, 13 Sep 2012 09:31:45 +0100 | From | "David Laight" <> |
| |
> Remove useless kfree() and clean up code related to the removal. ... > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c > index aa41485..30a6b17 100644 > --- a/drivers/isdn/gigaset/common.c > +++ b/drivers/isdn/gigaset/common.c > @@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors, > return drv; > > error: > - kfree(drv->cs); > kfree(drv); > return NULL; > } >
Seems to me that (assuming kfree(NULL) is ok) the kfree() is best left in - just in case some other error path is added after drv->cs is assigned. Better safe than a memory leak.
David
|  |