lkml.org 
[lkml]   [2012]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ_TABLE
From
On 13 September 2012 03:06, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> cpu_cooling.c (CONFIG_CPU_THERMAL) uses cpu frequency table
> intefaces so it should select CPU_FREQ_TABLE.
> Fixes these build errors:
>
> drivers/built-in.o: In function `cpufreq_get_max_state':
> cpu_cooling.c:(.text+0x4e1297): undefined reference to `cpufreq_frequency_get_table'
> drivers/built-in.o: In function `cpufreq_set_cur_state':
> cpu_cooling.c:(.text+0x4e138b): undefined reference to `cpufreq_frequency_get_table'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Amit Daniel <amit.kachhap@linaro.org>
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Also, please add info in the MAINTAINERS file for drivers/thermal/.
>
> --- linux-next-20120912.orig/drivers/thermal/Kconfig
> +++ linux-next-20120912/drivers/thermal/Kconfig
> @@ -22,6 +22,7 @@ config THERMAL_HWMON
> config CPU_THERMAL
> bool "generic cpu cooling support"
> depends on THERMAL && CPU_FREQ
> + select CPU_FREQ_TABLE

This change looks good to me. Even similar select is present platform
cpufreq drivers which uses the cpufreq API's.

Thanks,
Amit Daniel
> help
> This implements the generic cpu cooling mechanism through frequency
> reduction, cpu hotplug and any other ways of reducing temperature. An


\
 
 \ /
  Last update: 2012-09-13 11:21    [W:0.046 / U:8.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site