Messages in this thread |  | | Date | Thu, 13 Sep 2012 16:09:55 +0800 | From | Mark Brown <> | Subject | Re: [PATCH v6 1/4] Runtime Interpreted Power Sequences |
| |
On Wed, Sep 12, 2012 at 06:57:44PM +0900, Alexandre Courbot wrote: > Some device drivers (panel backlights especially) need to follow precise > sequences for powering on and off, involving gpios, regulators, PWMs > with a precise powering order and delays to respect between each steps. > These sequences are board-specific, and do not belong to a particular > driver - therefore they have been performed by board-specific hook > functions to far.
It does make me a little sad that the DT bindings need to specify the number of steps but otherwise this looks good (modulo the minor comments Stephen had as well):
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
I think regardless of the current discussion about some of the applications (like pwm-backlight) there are going to be cases where this is useful even if it ends up being more as library code for drivers than as something that users work with directly.
|  |