lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings
On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
> On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
> > From: J Keerthy <j-keerthy@ti.com>
> >
> > Removes checkpatch warnings on omap-bandgap.c.
> >
>
> Which checkpatch.pl warnings?
>
> > + omap_bandgap_writel(bg_ptr,
> > + rval->tshut_threshold,
> > + tsr->tshut_threshold);
>
> That's just whacky.
>
> Personally, I've never cared much about long lines, so I'd prefer
> to leave these as is until someone can break the functions up and
> remove them in a proper way instead of just shifting everything
> randomly to the left.
>

Sorry, that was my default response without looking at the code.

This is already broken up into small functions pretty nicely. You
might want to consider using shorter names. For example
omap_bandgap_writel() could be changed to "obg_writel()" and "bg_ptr"
could be changed to just "bg" because it's obviously a pointer.

regards,
dan carpenter


\
 
 \ /
  Last update: 2012-09-12 11:21    [W:0.071 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site