lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset to all module int nos
Date
On Thu, Sep 13, 2012 at 03:22:32, Tony Lindgren wrote:
> * Vaibhav Hiremath <hvaibhav@ti.com> [120912 14:17]:
> > With recent migration of omap architectures to SPARSE_IRQ framework,
> > it is important to add OMAP_INTC_START to all interrupt numbers
> > which will be eventually requested by drivers.
> >
> > This is required in order to get AM33XX boot functionality.
> >
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > ---
> > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 168 ++++++++++++++--------------
> > 1 files changed, 84 insertions(+), 84 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > index 7b7ed08..3c320f4 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
>
> You should just have on top of this file:
>
> #define OMAP_INTC_START 0
>
> Then Paul can apply this, and while merging with the sparseirq
> changes, the above can be removed.
>

Ok, I will add this at the top of the file and resend this patch.


> > @@ -72,7 +72,7 @@ static struct omap_hwmod_class am33xx_emif_hwmod_class = {
> > };
> >
> > static struct omap_hwmod_irq_info am33xx_emif_irqs[] = {
> > - { .name = "ddrerr0", .irq = 101 },
> > + { .name = "ddrerr0", .irq = 101 + OMAP_INTC_START },
> > { .irq = -1 }
> > };
> >
>
> Then these should be fixed up to have trailing commas
> as requested by Russell earlier on several occasions.
>

Ok, I will fix this and all other places as well and resend.

Thanks,
Vaibhav



\
 
 \ /
  Last update: 2012-09-13 00:21    [W:0.075 / U:3.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site