[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] staging/vme: Use pr_ printks in vme_user.c
On Wed, Sep 12, 2012 at 4:08 AM, Greg Kroah-Hartman
<> wrote:
> On Tue, Sep 11, 2012 at 04:16:14PM +0900, Toshiaki Yamane wrote:
>> The below checkpatch warnings was fixed,
>> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
>> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
>> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
> A lot of these can be using dev_* instead of the pr_* functions, right?
> Please convert to using them wherever possible.
> Because of that, I can't take this patch, sorry. Care to redo it?

Yes. Is this collect?

I must use dev_* procedure when the following conditions are met:
- If I have access to struct device object by the argument of the procedure
- Except for the right: struct net_device, etc.

Otherwise, I must use pr_* procedure.


YAMANE Toshiaki

 \ /
  Last update: 2012-09-12 10:01    [W:0.075 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site