lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] tracing,x86: add a TSC trace_clock; reset buffer on clock change
On Tue, Sep 11, 2012 at 8:48 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 2012-09-11 at 19:41 -0700, David Sharp wrote:
>> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
>> index 5c38c81..dc1f1fa 100644
>> --- a/kernel/trace/trace.c
>> +++ b/kernel/trace/trace.c
>> @@ -480,6 +480,9 @@ static struct {
>> { trace_clock_local, "local" },
>> { trace_clock_global, "global" },
>> { trace_clock_counter, "counter" },
>> +#ifdef CONFIG_X86_TSC
>> + { trace_clock_tsc, "tsc" },
>> +#endif
>> };
>
> I really hate adding arch defs in generic code. Perhaps what we could do
> is add a define here. Something like:
>
> #ifndef ARCH_TRACE_CLOCKS
> # define ARCH_TRACE_CLOCKS
> #endif
>
> [...]
> { trace_clock_counter, "counter" },
> ARCH_TRACE_CLOCKS
> };
>
> and have ARCH_TRACE_CLOCKS defined somewhere in an arch specific header.
> Not sure what header we could use though :-/
>
> That is, in a header have:
>
> #define ARCH_TRACE_CLOCKS \
> { trace_clock_x86_tsc, "tsc" },
>
> and also define trace_clock_x86_tsc in arch/x86/kernel...

Good point. I'll figure out somewhere better to put it...


\
 
 \ /
  Last update: 2012-09-12 21:21    [W:0.076 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site