lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH] perf, intel: Don't touch MSR_IA32_DEBUGCTLMSR from NMI context
From
On Wed, Sep 12, 2012 at 7:45 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, 2012-09-12 at 19:37 +0200, Peter Zijlstra wrote:
>> Ah, so I do think EIO will re-enable LBR,
>
> OK, it does not, but the:
>
>> also the handler is wrapped in
>> x86_pmu::{dis,en}able_all() which does end up calling
>> intel_pmu_lbr_{dis,en}able_all().
>
> Thing does the re-enable for us,
>

>> However that leaves the MSR in the
>> exact same state on exit as it was on enter, so that's not a problem for
>> the: read-modify-write change.
>
> in a safe way.
Well, I think it does even when we have to stop events (x86_pmu_stop)
because the buffer is full. Looks like we always re-enable lbr. So looks
like the handler is a wash for debugctl.


\
 
 \ /
  Last update: 2012-09-12 20:41    [W:0.071 / U:35.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site