Messages in this thread | | | Date | Wed, 12 Sep 2012 08:54:18 -0600 | From | David Ahern <> | Subject | Re: [PATCH] perf, tools: Stop perf stat -p when profiled process exits v2 |
| |
On 9/12/12 8:40 AM, Andi Kleen wrote: > - while(!done) sleep(1); > + char piddir[40]; > + if (target.pid && access("/proc", X_OK) == 0) > + snprintf(piddir, sizeof piddir, "/proc/%d", atoi(target.pid));
else path has piddir not set. Also as Namyhung pointed out target.pid can have multiple pids in it, so this fails if a user specified -p pid1,pid2 -- it will only check if the first process died.
Perhaps a more generic perf_target__is_alive function is needed that can check if the given tid(s) or pid(s) have terminated.
David
| |