Messages in this thread | | | Subject | Re: [PATCH v2 1/3] hrtimer: add hrtimer_init_cpu() | From | Peter Zijlstra <> | Date | Wed, 12 Sep 2012 16:49:11 +0200 |
| |
On Wed, 2012-09-12 at 16:46 +0200, Stephane Eranian wrote:
> I am fine with dropping this patch. I just found it odd there was a per-cpu > data reference embedded deep into the call. I wanted things to be more > explicit. I know it works without the proposed change.
Ah the reason its there is to make sure the base pointer is a valid base pointer, this avoids an extra conditional in a number of places. Note that it uses raw_get_cpu_var(), so it doesn't even actually know which specific pointer goes in.
| |