lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf: Introduce function to report unsupported syscall attribute flags
From
Date
On Wed, 2012-09-12 at 07:26 -0700, Andi Kleen wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
>
> > On Wed, 2012-09-12 at 13:01 +0200, Robert Richter wrote:
> >> + if (notsup)
> >> + pr_warn("perf: unsupported attribute flags: %016llx\n", notsup);
> >
> > This is a dmesg DoS..
> >
> > I'm also not sure dmesg is the right way.. could we not somehow change
> > the attrs to provide better diagnostic?
>
> Have a output argument for a string, that is then printed by the user tool?
>
> I agree it's a problem today, i usually have to resort to ftrace to
> figure out what'swrong.

Yeah, its a pain.. something I was thinking of is zero-ing out the
entire perf_event_attr and set the field that caused the fail to all 1s
(for however many bits that field is wide).

It would destroy the user input, but it also would provide better
feedback on what exact field you went astray.




\
 
 \ /
  Last update: 2012-09-12 17:01    [W:0.086 / U:2.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site