lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] trace: Move trace event enable from fs_initcall to core_initcall
From
Date
On Wed, 2012-09-12 at 09:29 -0300, Ezequiel Garcia wrote:
> Steven,
>
> On Tue, Sep 11, 2012 at 9:34 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> ble(void)
> [...]
> >> + /*
> >> + * Early initialization already enabled ftrace event.
> >> + * Now it's only necessary to create the event directory.
> >> + */
> >> for_each_event(call, __start_ftrace_events, __stop_ftrace_events) {
> >> - __trace_add_event_call(*call, NULL, &ftrace_event_id_fops,
> >
> > Here, __trace_add_event_call() did the checks and did not create a
> > directory on raw_init() failure. But now there's no check, and we are
> > having events being created that should not be.
> >
>
> I believe the problem is we're iterating through every event
> defined in __start_ftrace_events.
> We should iterate through the events added to the ftrace_events list.

Yeah, that sounds like a better solution. I can't at the moment think of
anything where that would break.

Thanks,

-- Steve



\
 
 \ /
  Last update: 2012-09-12 17:01    [W:0.063 / U:2.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site