lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drivers/media: Removes useless kfree()
From
I'll split this patch in one patch for file and resend.

On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote:
>> diff --git a/drivers/media/dvb-frontends/lg2160.c b/drivers/media/dvb-frontends/lg2160.c
>> index cc11260..748da5d 100644
>> --- a/drivers/media/dvb-frontends/lg2160.c
>> +++ b/drivers/media/dvb-frontends/lg2160.c
>> @@ -1451,7 +1451,6 @@ struct dvb_frontend *lg2160_attach(const struct lg2160_config *config,
>> return &state->frontend;
>> fail:
>> lg_warn("unable to detect LG216x hardware\n");
>> - kfree(state);
>> return NULL;
>> }
>
> I wish you had fixed this the same as the others and removed the
> goto. Also the printk is redundant and wrong. Remove it too.
>
> regards,
> dan carpenter
>



--
Peter


\
 
 \ /
  Last update: 2012-09-12 15:41    [W:0.072 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site