lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/7] uprobes: single-step fixes
    * Oleg Nesterov <oleg@redhat.com> [2012-09-08 19:06:01]:

    > On 09/03, Oleg Nesterov wrote:
    > >
    > > Sebastian, I changed your patches a bit:
    > >
    > > 1/7:
    > >
    > > - Change the subject and update the changelog. In particular,
    > > s/utrace/uprobes/. I am wondering where this typo came from ;)
    >
    > Hmm. I just noticed this patch is buggy. arch_uprobe_disable_step(&uprobe->arch)
    > is not safe after put_uprobe().
    >
    > Srikar, I fixed this in my tree with the following change,
    >
    > --- kernel/events/uprobes.c~ 2012-09-02 16:52:54.000000000 +0200
    > +++ kernel/events/uprobes.c 2012-09-08 18:56:44.000000000 +0200
    > @@ -1536,10 +1536,10 @@ static void handle_singlestep(struct upr
    > else
    > WARN_ON_ONCE(1);
    >
    > + arch_uprobe_disable_step(&uprobe->arch);
    > put_uprobe(uprobe);
    > utask->active_uprobe = NULL;
    > utask->state = UTASK_RUNNING;
    > - arch_uprobe_disable_step(&uprobe->arch);
    > xol_free_insn_slot(current);
    >
    > spin_lock_irq(&current->sighand->siglock);
    >
    > I hope your ack is still valid.
    >

    Yes, Please merge this into 1/7 patch.

    --
    Thanks and Regards
    Srikar



    \
     
     \ /
      Last update: 2012-09-12 15:21    [W:4.215 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site