lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] scsi: create an all-zero filter for scanners
On Wed, 12 Sep 2012 13:23:43 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Using /dev/sg for scanners is blocked from unprivileged users. Reimplement
> this using customizable command filters, so that the sysfs knobs will work
> in this case too.
>
> Cc: linux-iscsi@vger.kernel.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> drivers/scsi/scsi_scan.c | 6 +++++-
> drivers/scsi/sg.c | 3 ---
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 56a9379..d168c15 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -773,13 +773,17 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
> }
>
> switch (sdev->type) {
> + case TYPE_SCANNER:
> + sdev->request_queue->cmd_filter =
> + kzalloc(sizeof(struct blk_cmd_filter), GFP_KERNEL);
> + /* fallthrough */

Is that really desireable in the kzalloc failing case ?



\
 
 \ /
  Last update: 2012-09-12 15:21    [W:0.054 / U:4.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site