Messages in this thread | | | Date | Tue, 11 Sep 2012 18:03:10 -0700 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 01/18] perf test: Remove die() calls |
| |
Em Wed, Sep 12, 2012 at 09:24:33AM +0900, Namhyung Kim escreveu: > Hi, Arnaldo > > On Tue, 11 Sep 2012 20:52:53 -0300, Arnaldo Carvalho de Melo wrote: > > From: Arnaldo Carvalho de Melo <acme@redhat.com> > > > > Just use pr_err() + return -1 and let the other tests run as well and > > then the perf's main() exit doing whatever it needs. > [snip] > > diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c > > index cf33e50..6ae102e 100644 > > --- a/tools/perf/builtin-test.c > > +++ b/tools/perf/builtin-test.c > > @@ -1023,14 +1023,16 @@ static int __test__rdpmc(void) > > > > fd = sys_perf_event_open(&attr, 0, -1, -1, 0); > > if (fd < 0) { > > - die("Error: sys_perf_event_open() syscall returned " > > - "with %d (%s)\n", fd, strerror(errno)); > > + pr_debug("Error: sys_perf_event_open() syscall returned " > > + "with %d (%s)\n", fd, strerror(errno)); > > s/pr_debug/pr_err/ ? > > Otherwise the message will not be shown unless -v option is given > - and it's not sync with the changelog ;-)
Oops :-\ Can you sent a fixup patch for this and the other case?
Thanks for the review!
- Arnaldo
| |