lkml.org 
[lkml]   [2012]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] DMA mapping error check analysis
    Shuah Khan wrote:
    > I analyzed all calls to dma_map_single() and dma_map_page() in the
    > kernel, to see if callers check for mapping errors, before using the
    > returned address.
    >
    > The goal of this analysis is to find drivers that currently do not
    > check dma mapping errors, and fix them.
    >
    > I documented the results of this analysis:
    >
    > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis

    > File Name # of calls Status
    > drivers/firewire/core-iso.c 1 Unmap Broken
    > drivers/firewire/ohci.c 1 Unmap Broken

    In ohci.c, ar_context_release() takes care of cleanup.

    In core-iso.c, on failure, the callers are responsible to call
    fw_iso_buffer_destroy() eventually. (ioctl_create_iso_context()
    doesn't do this correctly if it's called multiple times.)


    Regards,
    Clemens


    \
     
     \ /
      Last update: 2012-09-10 10:41    [W:0.034 / U:0.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site