Messages in this thread | | | Date | Mon, 10 Sep 2012 19:57:25 +0200 | From | Fabio Baltieri <> | Subject | Re: [PATCH] leds: add led_trigger_rename function |
| |
On Mon, Sep 10, 2012 at 03:55:35PM +0200, Kurt Van Dijck wrote: > On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote: > > Implements a led_trigger_rename() function to rename a trigger with > > proper locking. > This is the way to go. > Maybe add 'default_trigger' tests? In a later phase?
Do you think that default_trigger should be processed on renames? I usually think of default_trigger as something just on boot time, but that could make sense after all.
I think that could go for later phase anyway.
> > This also implies that "name" in "struct led_trigger" is not const > > anymore. > IMHO, this is wrong. This forces all other led_triggers > to put their name in non-const storage.
Uh - is that really a problem?
Fabio
-- Fabio Baltieri
| |