Messages in this thread | | | Date | Mon, 10 Sep 2012 14:21:49 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller |
| |
Hello.
On 10-09-2012 6:53, Xie Shaohui-B21989 wrote:
>>> + /* Workaround for data length mismatch errata */ >>> + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) { >>> + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) { >>> + qc = ata_qc_from_tag(ap, tag); >>> + if (qc && ata_is_atapi(qc->tf.protocol)) { >>> + u32 hcontrol; >>> +#define HCONTROL_CLEAR_ERROR (1 << 27)
>> shouldn't we have this #define be part of the enum that the other >> HCONTROL_ bits/flags are part of?
> [S.H] do you mean this?
Apparently not. He said *enum*, not #define.
> #ifdef SATA_FSL_XXX_ERRATUAM
We don't need that at all.
> #define HCONTROL_CLEAR_ERROR (1 << 27) > #endif
MBR, Sergei
| |