lkml.org 
[lkml]   [2012]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller
Hello.

On 10-09-2012 6:53, Xie Shaohui-B21989 wrote:

>>> + /* Workaround for data length mismatch errata */
>>> + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) {
>>> + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) {
>>> + qc = ata_qc_from_tag(ap, tag);
>>> + if (qc && ata_is_atapi(qc->tf.protocol)) {
>>> + u32 hcontrol;
>>> +#define HCONTROL_CLEAR_ERROR (1 << 27)

>> shouldn't we have this #define be part of the enum that the other
>> HCONTROL_ bits/flags are part of?

> [S.H] do you mean this?

Apparently not. He said *enum*, not #define.

> #ifdef SATA_FSL_XXX_ERRATUAM

We don't need that at all.

> #define HCONTROL_CLEAR_ERROR (1 << 27)
> #endif

MBR, Sergei



\
 
 \ /
  Last update: 2012-09-10 13:01    [W:0.075 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site