Messages in this thread | | | Date | Thu, 09 Aug 2012 16:17:22 -0700 (PDT) | Subject | Re: [PATCH net-next] time: jiffies_delta_to_clock_t() helper to the rescue | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Thu, 09 Aug 2012 09:13:53 +0200
> From: Eric Dumazet <edumazet@google.com> > > Various /proc/net files sometimes report crazy timer values, expressed > in clock_t units. > > This happens when an expired timer delta (expires - jiffies) is passed > to jiffies_to_clock_t(). > > This function has an overflow in : > > return div_u64((u64)x * TICK_NSEC, NSEC_PER_SEC / USER_HZ); > > commit cbbc719fccdb8cb (time: Change jiffies_to_clock_t() argument type > to unsigned long) only got around the problem. > > As we cant output negative values in /proc/net/tcp without breaking > various tools, I suggest adding a jiffies_delta_to_clock_t() wrapper > that caps the negative delta to a 0 value. > > Signed-off-by: Eric Dumazet <edumazet@google.com> > Reported-by: Maciej Żenczykowski <maze@google.com>
Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |