Messages in this thread | | | Date | Wed, 8 Aug 2012 23:34:09 -0700 | Subject | Re: [PATCH v5 05/12] block: Kill bi_destructor | From | Tejun Heo <> |
| |
Hello,
On Wed, Aug 8, 2012 at 11:12 PM, Kent Overstreet <koverstreet@google.com> wrote: > But if it's a pointer to heap allocated memory, but the bio was embedded > in another struct? I've seen a fair number of instances of that (md, off > the top of my head). > > If you're sure that in a normal config the slab allocator is going to > complain right away and not corrupt itself, fine. But I've been bitten > way too hard by bugs that could've been caught right away by a simple > assert and instead I had to spend hours backtracking, and the block > layer is _rife_ with that kind of thing.
Let's let slab debug code deal with that. I really don't see much benefit in doing this. The said kind of bugs aren't particularly difficult to track down.
Thanks.
-- tejun
| |